Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add integration test for stats task #37506

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #33744

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Nov 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 7, 2024
@xiaocai2333 xiaocai2333 requested review from czs007 and removed request for jiaoew1991 and wayblink November 7, 2024 08:52
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (5310d34) to head (55fa09e).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
tests/integration/util_query.go 42.85% 9 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37506      +/-   ##
==========================================
+ Coverage   80.54%   82.60%   +2.05%     
==========================================
  Files        1333     1043     -290     
  Lines      186990   161611   -25379     
==========================================
- Hits       150617   133500   -17117     
+ Misses      31113    22830    -8283     
- Partials     5260     5281      +21     
Components Coverage Δ
Client 52.03% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.25% <ø> (-0.03%) ⬇️
Files with missing lines Coverage Δ
tests/integration/util_query.go 84.07% <42.85%> (-2.28%) ⬇️

... and 316 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Nov 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 8, 2024
@sre-ci-robot sre-ci-robot merged commit ae227e3 into milvus-io:master Nov 8, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants