Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip EOF error when default empty yaml file #37445

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

congqixia
Copy link
Contributor

Related to #37404

Related to milvus-io#37404

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 5, 2024
Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (b83b376) to head (5eb6eef).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/config/file_source.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37445      +/-   ##
==========================================
- Coverage   83.26%   80.98%   -2.28%     
==========================================
  Files        1015     1305     +290     
  Lines      157473   182899   +25426     
==========================================
+ Hits       131115   148117   +17002     
- Misses      21166    29566    +8400     
- Partials     5192     5216      +24     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <ø> (∅)
Go 83.23% <0.00%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
pkg/config/file_source.go 77.14% <0.00%> (ø)

... and 313 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 0645d46 into milvus-io:master Nov 5, 2024
18 of 20 checks passed
@congqixia congqixia deleted the fix/skip_yaml_decode_eof branch November 6, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants