Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: alterindex & altercollection supports altering properties #37437

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JsDove
Copy link

@JsDove JsDove commented Nov 5, 2024

enhance :

  1. alterindex delete properties
    We have introduced a new parameter deleteKeys to the alterindex functionality, which allows for the deletion of properties within an index. This enhancement provides users with the flexibility to manage index properties more effectively by removing specific keys as needed.
  2. altercollection delete properties
    We have introduced a new parameter deleteKeys to the altercollection functionality, which allows for the deletion of properties within an collection. This enhancement provides users with the flexibility to manage collection properties more effectively by removing specific keys as needed.

3.support altercollectionfield
We currently support modifying the fieldparams of a field in a collection using altercollectionfield, which only allows changes to the max-length attribute.
Key Points:

  • New Parameter - deleteKeys: This new parameter enables the deletion of specified properties from an index. By passing a list of keys to deleteKeys, users can remove the corresponding properties from the index.

  • Mutual Exclusivity: The deleteKeys parameter cannot be used in conjunction with the extraParams parameter. Users must choose one parameter to pass based on their requirement. If deleteKeys is provided, it indicates an intent to delete properties; if extraParams is provided, it signifies the addition or update of properties.

issue: #37436

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
@sre-ci-robot
Copy link
Contributor

Welcome @JsDove! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file area/internal-api labels Nov 5, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JsDove
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Nov 5, 2024
Copy link
Contributor

mergify bot commented Nov 5, 2024

@JsDove

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Nov 5, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 5, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (caf207f) to head (77e7238).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37437   +/-   ##
=======================================
  Coverage   68.07%   68.07%           
=======================================
  Files         290      290           
  Lines       25455    25454    -1     
=======================================
  Hits        17328    17328           
+ Misses       8127     8126    -1     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.07% <ø> (+<0.01%) ⬆️
Go ∅ <ø> (∅)

see 1 file with indirect coverage changes

@JsDove JsDove changed the title enhance : alterindex delete properties enhance : alterindex delete properties Nov 5, 2024
@JsDove JsDove changed the title enhance : alterindex delete properties enhance : alterindex delete properties Nov 5, 2024
@JsDove JsDove changed the title enhance : alterindex delete properties enhance : alterindex support delete properties Nov 5, 2024
@JsDove JsDove changed the title enhance : alterindex support delete properties enhance: alterindex support delete properties Nov 5, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 5, 2024
@JsDove
Copy link
Author

JsDove commented Nov 5, 2024

/run-cpu-e2e

@JsDove
Copy link
Author

JsDove commented Nov 5, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 5, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 5, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Author

JsDove commented Nov 5, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 5, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Nov 8, 2024
Copy link
Contributor

mergify bot commented Nov 8, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 8, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove JsDove changed the title enhance: alterindex support delete properties enhance: alterindex&altercollection support delete properties and support altercollectionfield Nov 8, 2024
@JsDove JsDove changed the title enhance: alterindex&altercollection support delete properties and support altercollectionfield enhance: alterindex & altercollection supports altering properties Nov 8, 2024
Copy link
Contributor

mergify bot commented Nov 8, 2024

@JsDove cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 8, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 8, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove
Copy link
Author

JsDove commented Nov 11, 2024

rerun go-sdk

internal/proxy/task.go Outdated Show resolved Hide resolved
JsDove and others added 2 commits November 14, 2024 09:44
Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
Copy link
Contributor

mergify bot commented Nov 14, 2024

@JsDove cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@JsDove
Copy link
Author

JsDove commented Nov 14, 2024

rerun cpp-unit-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file area/internal-api dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants