-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: alterindex & altercollection supports altering properties #37437
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
Welcome @JsDove! It looks like this is your first PR to milvus-io/milvus 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JsDove The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@JsDove E2e jenkins job failed, comment |
@JsDove go-sdk check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37437 +/- ##
=======================================
Coverage 68.07% 68.07%
=======================================
Files 290 290
Lines 25455 25454 -1
=======================================
Hits 17328 17328
+ Misses 8127 8126 -1
|
/run-cpu-e2e |
rerun go-sdk |
@JsDove E2e jenkins job failed, comment |
@JsDove go-sdk check failed, comment |
/run-cpu-e2e |
@JsDove E2e jenkins job failed, comment |
Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
@JsDove E2e jenkins job failed, comment |
@JsDove go-sdk check failed, comment |
@JsDove cpp-unit-test check failed, comment |
@JsDove go-sdk check failed, comment |
@JsDove E2e jenkins job failed, comment |
rerun go-sdk |
Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
@JsDove cpp-unit-test check failed, comment |
rerun cpp-unit-test |
enhance :
We have introduced a new parameter deleteKeys to the alterindex functionality, which allows for the deletion of properties within an index. This enhancement provides users with the flexibility to manage index properties more effectively by removing specific keys as needed.
We have introduced a new parameter deleteKeys to the altercollection functionality, which allows for the deletion of properties within an collection. This enhancement provides users with the flexibility to manage collection properties more effectively by removing specific keys as needed.
3.support altercollectionfield
We currently support modifying the fieldparams of a field in a collection using altercollectionfield, which only allows changes to the max-length attribute.
Key Points:
New Parameter - deleteKeys: This new parameter enables the deletion of specified properties from an index. By passing a list of keys to deleteKeys, users can remove the corresponding properties from the index.
Mutual Exclusivity: The deleteKeys parameter cannot be used in conjunction with the extraParams parameter. Users must choose one parameter to pass based on their requirement. If deleteKeys is provided, it indicates an intent to delete properties; if extraParams is provided, it signifies the addition or update of properties.
issue: #37436