Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add SearchOnSealed unit test and fix a bug #37241

Merged
merged 6 commits into from
Oct 30, 2024
Merged

fix: add SearchOnSealed unit test and fix a bug #37241

merged 6 commits into from
Oct 30, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Oct 29, 2024 •
edited
Loading

issue: #37244

@sunby
fix: add SearchOnSealed unit test and fix a bug
b830887 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Oct 29, 2024
@sunby
fix
4eb9830 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 29, 2024
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@sunby
fix
249118d 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sunby
fix
87931d3 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
fix format
ad21808 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Oct 29, 2024

/run-cpu-e2e

@sunby
Copy link
Contributor Author

sunby commented Oct 29, 2024

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sunby
fix
189382b 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Oct 29, 2024

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (3106384) to head (189382b).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37241      +/-   ##
==========================================
- Coverage   83.15%   80.91%   -2.25%     
==========================================
  Files        1029     1319     +290     
  Lines      157251   182686   +25435     
==========================================
+ Hits       130768   147819   +17051     
- Misses      21324    29706    +8382     
- Partials     5159     5161       +2
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.12% <100.00%> (∅)
Go 83.16% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/mmap/ChunkedColumn.h 9.23% <100.00%> (ø)
internal/core/src/query/SearchOnSealed.cpp 95.19% <100.00%> (ø)

... and 312 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Oct 29, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Oct 29, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 29, 2024
@PwzXxm
Copy link
Contributor

PwzXxm commented Oct 30, 2024

/lgtm

congqixia
congqixia approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 90948e9 into milvus-io:master Oct 30, 2024
19 of 20 checks passed
sunby added a commit to sunby/milvus that referenced this pull request Oct 30, 2024
@sunby
fix: add SearchOnSealed unit test and fix a bug (milvus-io#37241)
552b10e 
issue: milvus-io#37244

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PwzXxm PwzXxm PwzXxm left review comments

@congqixia congqixia congqixia approved these changes

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@PwzXxm PwzXxm

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunby @PwzXxm @sre-ci-robot @congqixia