fix: use binlog counter to trigger flush but not stats log #37037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
chyezh
commented
Oct 22, 2024
| Name: "append_message_duration_seconds", | ||
| Help: "Duration of wal append message", | ||
| Buckets: secondsBuckets, | ||
| }, WALChannelLabelName, StatusLabelName) | ||
|
|
||
| WALImplsAppendMessageDurationSeconds = newStreamingNodeHistogramVec(prometheus.HistogramOpts{ | ||
| WALImplsAppendMessageDurationSeconds = newWALHistogramVec(prometheus.HistogramOpts{ |
There was a problem hiding this comment.
wrong metric subsystem, fixed
|
@chyezh E2e jenkins job failed, comment |
|
/run-cpu-e2e |
chyezh
force-pushed
the
fix_allocation_policy_wrong_using
branch
2 times, most recently
from
b3349ab to
1a7a167
Compare
Signed-off-by: chyezh <chyezh@outlook.com>
chyezh
force-pushed
the
fix_allocation_policy_wrong_using
branch
from
1a7a167 to
9e4982a
Compare
chyezh
commented
Oct 23, 2024
| @@ -161,10 +161,12 @@ func sealL1SegmentByLifetime(lifetime time.Duration) segmentSealPolicyFunc { | |||
| func sealL1SegmentByBinlogFileNumber(maxBinlogFileNumber int) segmentSealPolicyFunc { | |||
| return func(segment *SegmentInfo, ts Timestamp) (bool, string) { | |||
| logFileCounter := 0 | |||
| for _, fieldBinlog := range segment.GetStatslogs() { | |||
| for _, fieldBinlog := range segment.GetBinlogs() { | |||
There was a problem hiding this comment.
After stats task enabled, the statslog cannot be used here.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #36804