fix: add proportion for capacity seal policy in streaming flusher #36761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
sre-ci-robot
added
size/L
|
rerun ut |
chyezh
force-pushed
the
fix_add_growing_size_ratio_for_flush
branch
from
6fcde7f to
4df2764
Compare
|
rerun ut |
1 similar comment
|
rerun ut |
chyezh
force-pushed
the
fix_add_growing_size_ratio_for_flush
branch
from
4df2764 to
15f5f96
Compare
Signed-off-by: chyezh <chyezh@outlook.com>
…lusher Signed-off-by: chyezh <chyezh@outlook.com>
chyezh
force-pushed
the
fix_add_growing_size_ratio_for_flush
branch
from
15f5f96 to
5849b30
Compare
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36761 +/- ##
==========================================
+ Coverage 72.47% 81.48% +9.01%
==========================================
Files 1308 1308
Lines 155968 155986 +18
==========================================
+ Hits 113036 127108 +14072
+ Misses 37822 23759 -14063
- Partials 5110 5119 +9
|
chyezh
commented
Oct 14, 2024
| @@ -46,13 +47,15 @@ func (p jitterSegmentLimitationPolicy) GenerateLimitation() SegmentLimitation { | |||
| jitterRatio = 1 | |||
| } | |||
| maxSegmentSize := uint64(paramtable.Get().DataCoordCfg.SegmentMaxSize.GetAsInt64() * 1024 * 1024) | |||
| segmentSize := uint64(jitterRatio * float64(maxSegmentSize)) | |||
| proportion := paramtable.Get().DataCoordCfg.SegmentSealProportion.GetAsFloat() | |||
There was a problem hiding this comment.
add proportion configuration here.
| // It's an async update operation, so it's not necessary to do success. | ||
| func (m *StatsManager) UpdateOnFlush(segmentID int64, flush FlushOperationMetrics) { | ||
| func (m *StatsManager) UpdateOnSync(segmentID int64, syncMetric SyncOperationMetrics) { |
There was a problem hiding this comment.
update binglog count when syncmgr make syncing.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #36760