Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check string array max length after type matching #36449

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36029

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 23, 2024
Copy link
Contributor

mergify bot commented Sep 23, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Sep 23, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.33%. Comparing base (ed95568) to head (16bd0c2).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/validate_util.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #36449    +/-   ##
========================================
  Coverage   82.33%   82.33%            
========================================
  Files        1278     1279     +1     
  Lines      150879   151252   +373     
========================================
+ Hits       124219   124532   +313     
- Misses      21667    21711    +44     
- Partials     4993     5009    +16     
Files with missing lines Coverage Δ
internal/proxy/validate_util.go 90.56% <77.77%> (-0.02%) ⬇️

... and 28 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333 xiaocai2333 force-pushed the fix_array_element_check branch from f5ae46f to 440c2d1 Compare September 24, 2024 09:08
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Sep 27, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 50905e0 into milvus-io:master Sep 27, 2024
15 of 16 checks passed
sre-ci-robot pushed a commit that referenced this pull request Sep 27, 2024
…36497)

issue: #36029 

master pr: #36449

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 deleted the fix_array_element_check branch November 8, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants