Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add split_cluster_writer to support vshard/clustering compactor #36447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wayblink
Copy link
Contributor

issue: #36446

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Sep 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 23, 2024
@mergify mergify bot added the ci-passed label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 64.51613% with 77 lines in your changes missing coverage. Please review.

Project coverage is 81.46%. Comparing base (06b5e18) to head (baab16b).
Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
...ternal/datanode/compaction/split_cluster_writer.go 63.44% 49 Missing and 4 partials ⚠️
internal/datanode/compaction/segment_writer.go 62.50% 14 Missing and 7 partials ⚠️
internal/datanode/compaction/compactor_common.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36447      +/-   ##
==========================================
+ Coverage   72.53%   81.46%   +8.92%     
==========================================
  Files        1308     1312       +4     
  Lines      156263   189106   +32843     
==========================================
+ Hits       113351   154061   +40710     
+ Misses      37801    29868    -7933     
- Partials     5111     5177      +66     
Files with missing lines Coverage Δ
...ternal/datanode/compaction/clustering_compactor.go 72.95% <100.00%> (+4.00%) ⬆️
internal/datanode/compaction/merge_sort.go 73.52% <100.00%> (+0.68%) ⬆️
internal/datanode/compaction/mix_compactor.go 76.47% <100.00%> (-1.56%) ⬇️
internal/storage/primary_key.go 70.76% <100.00%> (-2.60%) ⬇️
internal/datanode/compaction/compactor_common.go 83.83% <66.66%> (-2.44%) ⬇️
internal/datanode/compaction/segment_writer.go 74.72% <62.50%> (-5.59%) ⬇️
...ternal/datanode/compaction/split_cluster_writer.go 63.44% <63.44%> (ø)

... and 1191 files with indirect coverage changes

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@wayblink
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Oct 17, 2024
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Oct 22, 2024
@mergify mergify bot removed the ci-passed label Oct 22, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Oct 22, 2024
@mergify mergify bot added the ci-passed label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants