Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable to write multiple segments in mix compactor #35705

Merged

Conversation

XuanYang-cn
Copy link
Contributor

Prevent segments to be written larger than maxSize * expansionRate

See also: #35584

Signed-off-by: yangxuan xuan.yang@zilliz.com

…o#35648)

Prevent segments to be written larger than maxSize * expansionRate

See also: milvus-io#35584

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 78.87324% with 60 lines in your changes missing coverage. Please review.

Project coverage is 72.28%. Comparing base (56b3490) to head (3f06087).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
internal/datanode/compaction/segment_writer.go 68.93% 21 Missing and 11 partials ⚠️
internal/datanode/compaction/mix_compactor.go 83.56% 10 Missing and 2 partials ⚠️
internal/datacoord/compaction_trigger.go 71.79% 9 Missing and 2 partials ⚠️
internal/datacoord/meta.go 93.75% 1 Missing and 2 partials ⚠️
internal/datacoord/compaction_task_mix.go 85.71% 0 Missing and 1 partial ⚠️
internal/datacoord/compaction_trigger_v2.go 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35705      +/-   ##
==========================================
- Coverage   81.32%   72.28%   -9.04%     
==========================================
  Files        1238     1238              
  Lines      148082   148116      +34     
==========================================
- Hits       120425   107063   -13362     
- Misses      22887    36270   +13383     
- Partials     4770     4783      +13     
Files with missing lines Coverage Δ
...ternal/datanode/compaction/clustering_compactor.go 67.45% <100.00%> (ø)
internal/datanode/compaction/compactor_common.go 88.80% <100.00%> (+0.46%) ⬆️
internal/datacoord/compaction_task_mix.go 63.40% <85.71%> (+0.31%) ⬆️
internal/datacoord/compaction_trigger_v2.go 72.65% <83.33%> (-0.83%) ⬇️
internal/datacoord/meta.go 89.89% <93.75%> (+0.05%) ⬆️
internal/datacoord/compaction_trigger.go 84.93% <71.79%> (-2.35%) ⬇️
internal/datanode/compaction/mix_compactor.go 77.12% <83.56%> (+6.48%) ⬆️
internal/datanode/compaction/segment_writer.go 76.03% <68.93%> (-8.52%) ⬇️

... and 230 files with indirect coverage changes

@bigsheeper
Copy link
Contributor

/lgtm

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@sre-ci-robot sre-ci-robot removed the lgtm label Aug 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 28, 2024
Copy link
Contributor

mergify bot commented Aug 28, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Aug 28, 2024
@wayblink
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 323400c into milvus-io:master Aug 30, 2024
13 of 16 checks passed
@XuanYang-cn XuanYang-cn deleted the enhance/enable-to-spilt-segments branch August 30, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants