Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix offset out of range for creating Trie index #35553

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #35550

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Aug 19, 2024
@smellthemoon
Copy link
Contributor

/lgtm

@xiaocai2333
Copy link
Contributor Author

rerun ut

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (4d69898) to head (666b094).
Report is 36 commits behind head on master.

Files Patch % Lines
internal/core/src/index/StringIndexMarisa.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35553      +/-   ##
==========================================
+ Coverage   72.38%   81.45%   +9.07%     
==========================================
  Files        1234     1229       -5     
  Lines      145723   146128     +405     
==========================================
+ Hits       105475   119028   +13553     
+ Misses      35691    22552   -13139     
+ Partials     4557     4548       -9     
Files Coverage Δ
internal/core/src/index/StringIndexMarisa.cpp 65.90% <0.00%> (+65.90%) ⬆️

... and 289 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Aug 21, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Aug 25, 2024
@sre-ci-robot sre-ci-robot merged commit 615a653 into milvus-io:master Aug 25, 2024
13 of 16 checks passed
@xiaocai2333 xiaocai2333 deleted the fix_offset_out_range branch September 25, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants