Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable milvus.yaml check (#34567) #35446

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: enable milvus.yaml check (#34567) #35446

merged 2 commits into from
Aug 13, 2024

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Aug 13, 2024 •
edited
Loading

See #32168

pr: #34567 #35152

@tedxu
fix: enable milvus.yaml check (milvus-io#34567)
11346e6 
See milvus-io#32168

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 13, 2024

@tedxu Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Aug 13, 2024
@tedxu
enhance: update param documents (milvus-io#35152)
3876beb 
See: milvus-io#35161

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Aug 13, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@weiliu1031
Copy link
Contributor

/lgtm

@mergify mergify bot added the ci-passed label Aug 13, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.91%. Comparing base (acd3c53) to head (3876beb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35446      +/-   ##
==========================================
- Coverage   81.24%   71.91%   -9.34%     
==========================================
  Files        1051     1056       +5     
  Lines      138254   137970     -284     
==========================================
- Hits       112325    99219   -13106     
- Misses      21701    34522   +12821     
- Partials     4228     4229       +1
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.57% <100.00%> (+0.01%) ⬆️
pkg/util/paramtable/grpc_param.go 80.22% <100.00%> (+0.07%) ⬆️
pkg/util/paramtable/quota_param.go 74.83% <100.00%> (+0.06%) ⬆️
pkg/util/paramtable/service_param.go 98.29% <100.00%> (+0.07%) ⬆️

... and 289 files with indirect coverage changes

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ce53e79 into milvus-io:2.4 Aug 13, 2024
14 of 15 checks passed
@tedxu tedxu deleted the cp/2.4_35152 branch August 13, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@weiliu1031 weiliu1031

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tedxu @weiliu1031 @congqixia @sre-ci-robot