Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add integration tests for l0 #35430

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Aug 12, 2024

pr: #35429
See also: #34796

pr: milvus-io#35429

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test labels Aug 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.91%. Comparing base (bafc5a8) to head (1ded0d4).
Report is 24 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #35430       +/-   ##
===========================================
+ Coverage   71.90%   84.91%   +13.01%     
===========================================
  Files        1056      788      -268     
  Lines      137827   113795    -24032     
===========================================
- Hits        99104    96631     -2473     
+ Misses      34495    12928    -21567     
- Partials     4228     4236        +8     
Files Coverage Δ
...ternal/datanode/compaction/clustering_compactor.go 67.63% <100.00%> (ø)
internal/datanode/compaction/compactor_common.go 91.81% <100.00%> (ø)

... and 294 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4a5e6bc into milvus-io:2.4 Aug 19, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the add-integration branch August 21, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants