Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix empty indices of sparse float #35403

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Aug 9, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Aug 9, 2024
Copy link
Contributor

mergify bot commented Aug 9, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@czs007
Copy link
Collaborator

czs007 commented Aug 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunby sunby force-pushed the fix_sparse_mmap_master branch from db35931 to aa07b4a Compare August 26, 2024 06:26
@sre-ci-robot sre-ci-robot removed the lgtm label Aug 26, 2024
@sunby sunby force-pushed the fix_sparse_mmap_master branch from aa07b4a to 7b1151c Compare September 10, 2024 03:36
Copy link
Contributor

mergify bot commented Sep 10, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Sep 10, 2024

rerun go-sdk

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby sunby force-pushed the fix_sparse_mmap_master branch from 7b1151c to 6fd5c11 Compare September 10, 2024 04:05
@mergify mergify bot added the ci-passed label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (5aedc16) to head (6fd5c11).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/mmap/Utils.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35403      +/-   ##
==========================================
- Coverage   81.60%   72.63%   -8.98%     
==========================================
  Files        1268     1268              
  Lines      151077   151078       +1     
==========================================
- Hits       123283   109728   -13555     
- Misses      22895    36452   +13557     
+ Partials     4899     4898       -1     
Files with missing lines Coverage Δ
internal/core/src/mmap/Utils.h 0.00% <0.00%> (-71.24%) ⬇️

... and 236 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 10, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 53a8a24 into milvus-io:master Sep 10, 2024
14 of 16 checks passed
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants