Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minio use virtual config to not panic #35327

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

xiaofan-luan
Copy link
Collaborator

minio use virtual should not panic if empty. User may use other object storage instead

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
@xiaofan-luan xiaofan-luan added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 6, 2024
@xiaofan-luan xiaofan-luan added this to the 2.5.0 milestone Aug 6, 2024
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 6, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Aug 6, 2024
Copy link
Contributor

mergify bot commented Aug 6, 2024

@xiaofan-luan

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (a2b5175) to head (9a8a5b1).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35327      +/-   ##
==========================================
- Coverage   84.90%   81.59%   -3.32%     
==========================================
  Files         938     1222     +284     
  Lines      119028   143323   +24295     
==========================================
+ Hits       101059   116942   +15883     
- Misses      13545    21960    +8415     
+ Partials     4424     4421       -3     
Files Coverage Δ
pkg/util/paramtable/service_param.go 98.29% <100.00%> (ø)

... and 334 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Aug 7, 2024

/lgtm

@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Aug 7, 2024
@sre-ci-robot sre-ci-robot merged commit 885d891 into milvus-io:master Aug 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/invalid-pr-format kind/improvement Changes related to something improve, likes ut and code refactor lgtm PR | need cherry-pick need cherry pick to other branches size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants