-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change minio use virtual config to not panic #35327
Conversation
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35327 +/- ##
==========================================
- Coverage 84.90% 81.59% -3.32%
==========================================
Files 938 1222 +284
Lines 119028 143323 +24295
==========================================
+ Hits 101059 116942 +15883
- Misses 13545 21960 +8415
+ Partials 4424 4421 -3
|
/lgtm |
minio use virtual should not panic if empty. User may use other object storage instead