Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add more ut for l0CompactionTask #35100

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #34796

See also: milvus-io#34796

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 30, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jul 30, 2024
See also: milvus-io#34796
pr: milvus-io#35100

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 30, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 31, 2024
See also: #34796
pr: #35100

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn
Copy link
Contributor Author

rerun ut

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.67%. Comparing base (a690370) to head (5b590d2).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #35100    +/-   ##
========================================
  Coverage   81.66%   81.67%            
========================================
  Files        1215     1210     -5     
  Lines      142757   143166   +409     
========================================
+ Hits       116585   116932   +347     
- Misses      21762    21821    +59     
- Partials     4410     4413     +3     
Files Coverage Δ
internal/datacoord/compaction_task_l0.go 100.00% <100.00%> (+16.33%) ⬆️

... and 239 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 5, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 06f9ba2 into milvus-io:master Aug 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants