Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refine error handle in clustering compaction task #34956

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

wayblink
Copy link
Contributor

related: #30633 #34792

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 24, 2024
@wayblink wayblink force-pushed the clustering-error branch 2 times, most recently from 8bb798d to 99d482b Compare July 25, 2024 02:08
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (e2f40fc) to head (f840db7).
Report is 43 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #34956       +/-   ##
===========================================
+ Coverage    9.95%   81.01%   +71.06%     
===========================================
  Files         271     1185      +914     
  Lines       24629   143095   +118466     
===========================================
+ Hits         2451   115931   +113480     
- Misses      22178    22759      +581     
- Partials        0     4405     +4405     
Files Coverage Δ
internal/datacoord/compaction.go 72.06% <100.00%> (ø)
internal/datacoord/compaction_task_clustering.go 67.72% <82.75%> (ø)

... and 1114 files with indirect coverage changes

sre-ci-robot pushed a commit that referenced this pull request Jul 25, 2024
…ask (#34958)

related: #30633 #34792
pr: #34956

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Jul 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Jul 30, 2024
@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jul 30, 2024
@sre-ci-robot sre-ci-robot merged commit f919b6e into milvus-io:master Jul 30, 2024
11 of 12 checks passed
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
…#34956)

related: milvus-io#30633 milvus-io#34792

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants