Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable use_index when some array expr #34894

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

zhagnlu
Copy link
Collaborator

@zhagnlu zhagnlu commented Jul 22, 2024

Signed-off-by: luzhang <luzhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 22, 2024
@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Jul 22, 2024

rerun ut

@mergify mergify bot added the ci-passed label Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (40e39ef) to head (9a95ef8).
Report is 43 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34894      +/-   ##
==========================================
+ Coverage   71.80%   80.89%   +9.08%     
==========================================
  Files        1180     1175       -5     
  Lines      142356   142713     +357     
==========================================
+ Hits       102220   115446   +13226     
+ Misses      35737    22857   -12880     
- Partials     4399     4410      +11     
Files Coverage Δ
...src/exec/expression/BinaryArithOpEvalRangeExpr.cpp 89.12% <100.00%> (+89.12%) ⬆️
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 84.57% <100.00%> (+84.57%) ⬆️
internal/core/src/exec/expression/Expr.h 84.61% <100.00%> (+83.29%) ⬆️
internal/core/src/exec/expression/TermExpr.cpp 81.08% <100.00%> (+81.08%) ⬆️
internal/core/src/exec/expression/UnaryExpr.cpp 84.80% <100.00%> (+84.80%) ⬆️

... and 284 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f77f536 into milvus-io:master Jul 28, 2024
11 of 12 checks passed
Copy link

@Yherealtita Yherealtita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
milvus-io#34797

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants