fix:fix retrieve raw data from bitmap array index #34848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luzhang <luzhang@zilliz.com>
mergify
bot
added
dco-passed
|
rerun ut |
1 similar comment
|
rerun ut |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34848 +/- ##
===========================================
- Coverage 84.44% 71.69% -12.76%
===========================================
Files 892 1170 +278
Lines 117033 142444 +25411
===========================================
+ Hits 98832 102122 +3290
- Misses 13832 35899 +22067
- Partials 4369 4423 +54
|
|
rerun ut |
czs007
reviewed
Jul 23, 2024
| @@ -44,6 +44,8 @@ const ( | |||
|
|
|||
| // Sparse Index Param | |||
| SparseDropRatioBuild = "drop_ratio_build" | |||
|
|
|||
| MaxBitmapCardinalityLimit = 1000 | |||
There was a problem hiding this comment.
Should this be made configurable?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, zhagnlu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
rerun ut |
sumitd2
pushed a commit
to sumitd2/milvus
that referenced
this pull request
Aug 6, 2024
milvus-io#34795 Signed-off-by: luzhang <luzhang@zilliz.com> Co-authored-by: luzhang <luzhang@zilliz.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34795