Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Tidy dc channel manager #34515

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Jul 9, 2024

See also: #34518

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot requested review from congqixia and cydrain July 9, 2024 06:36
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jul 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue labels Jul 9, 2024
Copy link
Contributor

mergify bot commented Jul 9, 2024

@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.91%. Comparing base (eeb03a0) to head (aeefb4e).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #34515       +/-   ##
===========================================
- Coverage   79.76%   57.91%   -21.85%     
===========================================
  Files        1127      269      -858     
  Lines      139415    24168   -115247     
===========================================
- Hits       111203    13997    -97206     
+ Misses      23919    10171    -13748     
+ Partials     4293        0     -4293     

see 859 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 314f4d9 into milvus-io:master Jul 9, 2024
10 of 12 checks passed
@XuanYang-cn XuanYang-cn deleted the tidy-cm branch July 10, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants