fix: Query may return deleted records #34501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cause the sort in `GetLevel0Deletions` will broken the corresponed order between pks and tss, then the pks and tss will be sorted in segment.Delete() interface. This PR remove this uncessary and incorrect sort progress to avoid query may return deleted records. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34501 +/- ##
==========================================
- Coverage 80.66% 79.74% -0.93%
==========================================
Files 1118 1118
Lines 138936 138975 +39
==========================================
- Hits 112076 110821 -1255
- Misses 22590 23873 +1283
- Partials 4270 4281 +11
|
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 9, 2024
issue: #34500 pr: #34501 cause the sort in `GetLevel0Deletions` will broken the corresponed order between pks and tss, then the pks and tss will be sorted in segment.Delete() interface. This PR remove this uncessary and incorrect sort progress to avoid query may return deleted records. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weiliu1031, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #34500
cause the sort in
GetLevel0Deletionswill broken the corresponed order between pks and tss, then the pks and tss will be sorted in segment.Delete() interface.This PR remove this uncessary and incorrect sort progress to avoid query may return deleted records.