fix: DataNode might OOM by estimating based on MemorySize #34201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also: milvus-io#34136 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
mergify
bot
added
dco-passed
XuanYang-cn
added a commit
to XuanYang-cn/milvus
that referenced
this pull request
Jun 26, 2024
See also: milvus-io#34136 pr: milvus-io#34201 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34201 +/- ##
==========================================
+ Coverage 80.84% 80.85% +0.01%
==========================================
Files 1085 1080 -5
Lines 137510 137860 +350
==========================================
+ Hits 111171 111471 +300
- Misses 22114 22159 +45
- Partials 4225 4230 +5
|
tedxu
reviewed
Jul 2, 2024
| @@ -556,6 +554,7 @@ dataNode: | |||
| readBufferSizeInMB: 16 # The data block size (in MB) read from chunk manager by the datanode during import. | |||
| compaction: | |||
| levelZeroBatchMemoryRatio: 0.05 # The minimal memory ratio of free memory for level zero compaction executing in batch mode | |||
| levelZeroMaxBatchSize: -1 # Max batch size refers to the max number of L1/L2 segments in a batch when executing L0 compaction. Default to -1, any value that is less than 1 means no limit. Valid range: >= 1. | |||
There was a problem hiding this comment.
nit: # Max batch (in bytes) ...
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #34136