Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add more tracing for l0 compactor #33435

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

XuanYang-cn
Copy link
Contributor

No description provided.

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby May 28, 2024 11:10
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 28, 2024
Copy link
Contributor

mergify bot commented May 28, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (7763718) to head (6153142).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #33435    +/-   ##
========================================
  Coverage   82.12%   82.12%            
========================================
  Files        1015     1006     -9     
  Lines      129767   129984   +217     
========================================
+ Hits       106574   106754   +180     
- Misses      19231    19248    +17     
- Partials     3962     3982    +20     
Files Coverage Δ
internal/datanode/data_sync_service.go 67.88% <100.00%> (-0.50%) ⬇️
internal/datanode/l0_compactor.go 90.19% <100.00%> (+0.03%) ⬆️

... and 217 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 30, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0382628 into milvus-io:master Jun 3, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the enhance/add-tracing branch June 3, 2024 08:03
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants