Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allocate new slice for each batch in streaming reader #33359

Merged
merged 1 commit into from
May 24, 2024
Merged

fix: Allocate new slice for each batch in streaming reader #33359

merged 1 commit into from
May 24, 2024

Conversation

congqixia
Copy link
Contributor

Related to #33268

@congqixia
fix: Allocate new slice for each batch in streaming reader
d0577cc 
Related to milvus-io#33268

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels May 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 24, 2024
@congqixia congqixia mentioned this pull request May 24, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented May 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (e895cfe) to head (d0577cc).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33359      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.02%     
==========================================
  Files        1012     1012              
  Lines      128829   128848      +19     
==========================================
+ Hits       105793   105794       +1     
- Misses      19062    19074      +12     
- Partials     3974     3980       +6
Files Coverage Δ
internal/storage/serde.go 87.95% <100.00%> (-0.03%) ⬇️

... and 31 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 24, 2024
@tedxu
Copy link
Contributor

tedxu commented May 24, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 970bf18 into milvus-io:master May 24, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request May 24, 2024
@congqixia
fix: [2.4]Allocate new slice for each batch in streaming reader (#33360)
e2626c7 
Cherry-pick from master
pr: #33359
Related to #33268

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This was referenced May 27, 2024
Closed
Closed
@tedxu tedxu mentioned this pull request Jul 9, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jul 9, 2024
@tedxu
fix: reuse deserialize result to help improve memory management (#34507)
eae4dfc 
Fixed #33268
The original reuse is broken by #33359

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@tedxu tedxu

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @tedxu