Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add binlog import intergration test #32112

Merged
merged 4 commits into from
Apr 11, 2024
Merged

enhance: Add binlog import intergration test #32112

merged 4 commits into from
Apr 11, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #28521

@bigsheeper
enhance: Add binlog import intergration test
dea3f97 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/XL Denotes a PR that changes 500-999 lines. labels Apr 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Merge branch 'master' of https://github.com/milvus-io/milvus into 240…
4e00214 
…4-binlog-intergration-test
@bigsheeper
Merge branch 'master' of https://github.com/milvus-io/milvus into 240…
c93dc90 
…4-binlog-intergration-test
@bigsheeper
fix test
dbe6f4e 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (25a1c9e) to head (dbe6f4e).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32112      +/-   ##
==========================================
+ Coverage   81.68%   81.72%   +0.04%     
==========================================
  Files         990      990              
  Lines      121671   121688      +17     
==========================================
+ Hits        99382    99445      +63     
+ Misses      18484    18432      -52     
- Partials     3805     3811       +6
Files Coverage Δ
tests/integration/util_query.go 77.41% <70.58%> (-0.85%) ⬇️

... and 38 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Apr 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Apr 11, 2024

@bigsheeper pick to branch 2.4

@sre-ci-robot sre-ci-robot merged commit 273df98 into milvus-io:master Apr 11, 2024
14 of 15 checks passed
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Apr 11, 2024
@bigsheeper
enhance: Add binlog import intergration test (milvus-io#32112)
77eda3c 
issue: milvus-io#28521

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper bigsheeper mentioned this pull request Apr 11, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Apr 11, 2024
@bigsheeper
enhance: Add binlog import intergration test (#32112) (#32146)
246ef45 
issue: #28521

pr: #32112

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigsheeper @czs007 @sre-ci-robot