Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce didn't handle offset without limit and reduceStopForBest correctly #32089

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

xiaofan-luan
Copy link
Collaborator

fix #32059

this pr fix two issues:

offset is not handled correctly without specify a limit
reduceStopForBest doesn't guarantee to return limit result even if there are more result when there is small segment

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Apr 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 9, 2024
Copy link
Contributor

mergify bot commented Apr 10, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

…correctly

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
@MrPresent-Han
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (1b76766) to head (304f3c7).
Report is 17 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32089      +/-   ##
==========================================
- Coverage   81.63%   81.63%   -0.01%     
==========================================
  Files         978      989      +11     
  Lines      121665   121584      -81     
==========================================
- Hits        99326    99256      -70     
+ Misses      18525    18520       -5     
+ Partials     3814     3808       -6     
Files Coverage Δ
internal/proxy/task_query.go 80.90% <100.00%> (+0.81%) ⬆️
internal/querynodev2/segments/result.go 80.12% <100.00%> (-4.64%) ⬇️
pkg/util/typeutil/schema.go 85.00% <100.00%> (+0.19%) ⬆️

... and 246 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 10, 2024
@sre-ci-robot sre-ci-robot merged commit dbab9c5 into milvus-io:master Apr 10, 2024
15 checks passed
xiaofan-luan added a commit that referenced this pull request Apr 11, 2024
#32087)

fix #32059
pr: #32089

this pr fix two issues:
1. offset is not handled correctly without specify a limit
2. reduceStopForBest doesn't guarantee to return limit result even if
there are more result when there is small segment

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
xiaofan-luan added a commit that referenced this pull request Apr 11, 2024
#32088)

fix #32059
pr: #32089

this pr fix two issues:

offset is not handled correctly without specify a limit
reduceStopForBest doesn't guarantee to return limit result even if there
are more result when there is small segment

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
3 participants