-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce didn't handle offset without limit and reduceStopForBest correctly #32089
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xiaofan-luan E2e jenkins job failed, comment |
…correctly Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
7eeaf91
to
304f3c7
Compare
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32089 +/- ##
==========================================
- Coverage 81.63% 81.63% -0.01%
==========================================
Files 978 989 +11
Lines 121665 121584 -81
==========================================
- Hits 99326 99256 -70
+ Misses 18525 18520 -5
+ Partials 3814 3808 -6
|
fix #32059
this pr fix two issues:
offset is not handled correctly without specify a limit
reduceStopForBest doesn't guarantee to return limit result even if there are more result when there is small segment