Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mvcc database space exceeded for embed etcd #32048

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: mvcc database space exceeded for embed etcd #32048

merged 1 commit into from
Apr 12, 2024

Conversation

LoveEachDay
Copy link
Contributor

Fix #30314

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 9, 2024
@LoveEachDay
Copy link
Contributor Author

/cc @czs007

@sre-ci-robot sre-ci-robot requested a review from czs007 April 9, 2024 04:00
@LoveEachDay
Copy link
Contributor Author

/hold

@mergify mergify bot added the ci-passed label Apr 9, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LoveEachDay, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan
Copy link
Collaborator

@LoveEachDay
is their a reason to hold this pr?

@LoveEachDay
Copy link
Contributor Author

@LoveEachDay is their a reason to hold this pr?

@xiaofan-luan The deployment had been failed.
image
And our cpu-e2e-test won't take embedded milvus tests failure into account.

@LoveEachDay LoveEachDay force-pushed the change-embed-etcd-retention-config branch from f821022 to 3efb432 Compare April 12, 2024 06:17
@sre-ci-robot sre-ci-robot removed the lgtm label Apr 12, 2024
@mergify mergify bot removed the ci-passed label Apr 12, 2024
@LoveEachDay
Change etcd auto compaction config
3d2f156 
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
@LoveEachDay LoveEachDay force-pushed the change-embed-etcd-retention-config branch from 3efb432 to 3d2f156 Compare April 12, 2024 06:31
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 12, 2024

@LoveEachDay E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Apr 12, 2024
@LoveEachDay
Copy link
Contributor Author

/unhold

@yanliang567
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit b7ff856 into milvus-io:master Apr 12, 2024
4 checks passed
@zhuwenxing zhuwenxing mentioned this pull request Apr 15, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

@czs007 czs007 Awaiting requested review from czs007

Assignees

@yanliang567 yanliang567

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [one pod standalone]when Milvus recovers from pod kill chaos, most of its interfaces are not available
4 participants
@LoveEachDay @xiaofan-luan @sre-ci-robot @yanliang567