Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use an individual buffer size parameter for imports #31833

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

bigsheeper
Copy link
Contributor

Use an individual buffer size parameter for imports and set buffer size to 64MB.

issue: #28521

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 2, 2024
Copy link
Contributor

mergify bot commented Apr 2, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Apr 2, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (5429c35) to head (88e1135).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31833      +/-   ##
==========================================
+ Coverage   81.05%   81.09%   +0.04%     
==========================================
  Files         983      973      -10     
  Lines      140960   141341     +381     
==========================================
+ Hits       114254   114624     +370     
- Misses      22877    22905      +28     
+ Partials     3829     3812      -17     
Files Coverage Δ
internal/datanode/importv2/scheduler.go 82.85% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.38% <100.00%> (+<0.01%) ⬆️

... and 241 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Apr 2, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Apr 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Apr 8, 2024
…#31937)

Use an individual buffer size parameter for imports and set buffer size
to 64MB.

issue: #28521

pr: #31833

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot merged commit 49d109d into milvus-io:master Apr 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants