enhance: Return more fields in import progress response #31539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: enhance: Return more in import progress response Signed-off-by: bigsheeper <yihao.dai@zilliz.com> # The commit message #2 will be skipped: # support startTs, endTs # # Signed-off-by: bigsheeper <yihao.dai@zilliz.com> # The commit message #3 will be skipped: # add binlog import intergration test # # Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot
added
size/L
mergify
bot
added
dco-passed
|
@bigsheeper E2e jenkins job failed, comment |
|
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31539 +/- ##
==========================================
- Coverage 81.30% 80.71% -0.59%
==========================================
Files 987 972 -15
Lines 144687 137695 -6992
==========================================
- Hits 117631 111138 -6493
+ Misses 23139 22820 -319
+ Partials 3917 3737 -180
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bigsheeper need pick to branch 2.4 |
bigsheeper
added a commit
to bigsheeper/milvus
that referenced
this pull request
Mar 25, 2024
) Return more fields in import progress response, include importedRows and totalRows. Additionally, ensure compatibility with the old import progress response by retaining fields of create timestamp and row count. issue: milvus-io#31448 milvus-io#31237 milvus-io#28521 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Mar 25, 2024
) Return more fields in import progress response, include importedRows and totalRows. Additionally, ensure compatibility with the old import progress response by retaining fields of create timestamp and row count. issue: #31448 #31237 #28521 pr: #31539 Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return more fields in import progress response, include importedRows and totalRows. Additionally, ensure compatibility with the old import progress response by retaining fields of create timestamp and row count.
issue: #31448 #31237 #28521