Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add memory tracker #30830

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Feb 26, 2024

issue: #30822

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Feb 26, 2024

@sunby

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sunby sunby changed the title Add memory tracker feat: Add memory tracker Feb 26, 2024
@mergify mergify bot added kind/feature Issues related to feature request from users and removed do-not-merge/invalid-pr-format labels Feb 26, 2024
Copy link
Contributor

mergify bot commented Feb 26, 2024

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.71%. Comparing base (b31d1a1) to head (8c01c18).
Report is 1197 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30830      +/-   ##
==========================================
- Coverage   80.71%   80.71%   -0.01%     
==========================================
  Files         964      967       +3     
  Lines      137206   137355     +149     
==========================================
+ Hits       110749   110860     +111     
- Misses      22730    22769      +39     
+ Partials     3727     3726       -1     
Files Coverage Δ
internal/querycoordv2/meta/channel_dist_manager.go 100.00% <100.00%> (ø)
internal/querycoordv2/meta/target.go 94.11% <100.00%> (+3.79%) ⬆️
internal/querycoordv2/meta/target_manager.go 84.97% <100.00%> (+0.12%) ⬆️
internal/querycoordv2/server.go 80.50% <100.00%> (+0.06%) ⬆️
internal/util/memory/memory_tracker.go 94.87% <94.87%> (ø)

... and 22 files with indirect coverage changes

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Copy link
Contributor

mergify bot commented Feb 27, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Feb 29, 2024

/run-cpu-e2e

1 similar comment
@sunby
Copy link
Contributor Author

sunby commented Mar 1, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants