Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add collection level balancer switch #30411

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 31, 2024

No description provided.

sunby added 3 commits January 31, 2024 17:23
Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added area/internal-api size/L Denotes a PR that changes 100-499 lines. labels Jan 31, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 31, 2024

@sunby

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Jan 31, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby sunby changed the title Collection level balancer switch feat: add collection level balancer switch Feb 1, 2024
@mergify mergify bot added kind/feature Issues related to feature request from users do-not-merge/missing-related-issue and removed do-not-merge/invalid-pr-format labels Feb 1, 2024
Copy link
Contributor

mergify bot commented Feb 1, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (fb9d64a) 79.83% compared to head (82a6fb6) 79.93%.
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30411      +/-   ##
==========================================
+ Coverage   79.83%   79.93%   +0.10%     
==========================================
  Files         954      954              
  Lines      134860   134914      +54     
==========================================
+ Hits       107660   107839     +179     
+ Misses      23538    23416     -122     
+ Partials     3662     3659       -3     
Files Coverage Δ
internal/querycoordv2/checkers/balance_checker.go 92.47% <100.00%> (+0.08%) ⬆️
internal/querycoordv2/checkers/channel_checker.go 79.62% <100.00%> (+0.12%) ⬆️
internal/querycoordv2/checkers/leader_checker.go 86.36% <100.00%> (+0.10%) ⬆️
internal/querycoordv2/checkers/segment_checker.go 86.11% <100.00%> (+0.04%) ⬆️
internal/querycoordv2/checkers/checker.go 90.00% <81.81%> (-10.00%) ⬇️
internal/querycoordv2/checkers/index_checker.go 79.24% <0.00%> (-1.53%) ⬇️
internal/querycoordv2/checkers/controller.go 78.90% <26.66%> (-16.51%) ⬇️
internal/querycoordv2/ops_services.go 0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 6, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. do-not-merge/missing-related-issue kind/feature Issues related to feature request from users size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants