Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add more tests for groupby #30346

Merged
merged 4 commits into from
Jan 31, 2024
Merged

enhance: Add more tests for groupby #30346

merged 4 commits into from
Jan 31, 2024

Conversation

yanliang567
Copy link
Contributor

Related issue: #30033
skip the tests before bug fixes

@yanliang567
Add more tests for groupby
af0d357 
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@yanliang567
Remove useless logging import
0125948 
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@yanliang567 yanliang567 added this to the 2.4.0 milestone Jan 30, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved area/test sig/testing labels Jan 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Add skip mark for tests not ready to run
d6eb509 
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 31, 2024
wangting0128
wangting0128 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@wangting0128 wangting0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangting0128, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5415025 into milvus-io:master Jan 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangting0128 wangting0128 wangting0128 approved these changes

@binbinlv binbinlv Awaiting requested review from binbinlv

@ThreadDao ThreadDao Awaiting requested review from ThreadDao

Assignees

@wangting0128 wangting0128

@binbinlv binbinlv

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yanliang567 @sre-ci-robot @wangting0128 @binbinlv