Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix searchPlan metricType modified concurrently #30227

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 23, 2024

issue: #30225
/kind bug
Signed-off-by: xige-16 xi.ge@zilliz.com

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines. labels Jan 23, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jan 23, 2024
Copy link
Contributor

mergify bot commented Jan 23, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor

/run-cpu-e2e

@xige-16
Copy link
Contributor Author

xige-16 commented Jan 24, 2024

rerun ut

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c02fb64) 83.15% compared to head (9372e30) 79.92%.
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30227      +/-   ##
==========================================
- Coverage   83.15%   79.92%   -3.23%     
==========================================
  Files         701      948     +247     
  Lines      113325   133351   +20026     
==========================================
+ Hits        94230   106584   +12354     
- Misses      15473    23143    +7670     
- Partials     3622     3624       +2     
Files Coverage Δ
internal/core/src/segcore/Collection.h 100.00% <100.00%> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 81.03% <ø> (ø)
internal/core/src/segcore/SegmentInterface.cpp 94.33% <ø> (ø)
internal/core/src/segcore/SegmentInterface.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 77.87% <ø> (ø)
internal/core/src/segcore/plan_c.cpp 43.80% <100.00%> (ø)
internal/core/src/segcore/segment_c.cpp 63.29% <100.00%> (ø)
internal/querynodev2/segments/plan.go 75.00% <100.00%> (+5.27%) ⬆️

... and 255 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 24, 2024
Signed-off-by: xige-16 <xi.ge@zilliz.com>
@mergify mergify bot added ci-passed and removed ci-passed labels Jan 24, 2024
Signed-off-by: xige-16 <xi.ge@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jan 25, 2024
@mergify mergify bot removed the ci-passed label Jan 25, 2024
Copy link
Contributor

mergify bot commented Jan 25, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: xige-16 <xi.ge@zilliz.com>
Copy link
Contributor

mergify bot commented Jan 25, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Jan 25, 2024

/run-cpu-e2e

@xige-16
Copy link
Contributor Author

xige-16 commented Jan 25, 2024

rerun ut

Copy link
Contributor

mergify bot commented Jan 25, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Jan 25, 2024

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Jan 25, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Jan 25, 2024

/lgtm

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Jan 26, 2024
@mergify mergify bot added the ci-passed label Jan 26, 2024
@czs007
Copy link
Collaborator

czs007 commented Jan 26, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit e9fdd24 into milvus-io:master Jan 26, 2024
14 checks passed
@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Apr 24, 2024
Copy link
Contributor

mergify bot commented Apr 24, 2024

@xige-16 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot removed the ci-passed label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug Issues or changes related a bug lgtm needs-dco DCO is missing in this pull request. size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants