Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Opt metric type does not match error message #29927

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 12, 2024

issue: #29791
/kind improvement
Signed-off-by: xige-16 xi.ge@zilliz.com

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Jan 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1df3f90) 83.16% compared to head (249a87f) 83.17%.
Report is 55 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #29927    +/-   ##
========================================
  Coverage   83.16%   83.17%            
========================================
  Files         696      697     +1     
  Lines      111978   112222   +244     
========================================
+ Hits        93126    93338   +212     
- Misses      15314    15347    +33     
+ Partials     3538     3537     -1     

see 18 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 12, 2024
@czs007
Copy link
Collaborator

czs007 commented Jan 17, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fa7cf58 into milvus-io:master Jan 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants