Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Authorize users to query grant info of their roles (#29747) #29762

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Jan 8, 2024

Once a role is granted to a user, the user should automatically possess the privilege information associated with that role.

issue: #29710
pr: #29747

…9747)

Once a role is granted to a user, the user should automatically possess
the privilege information associated with that role.

issue: milvus-io#29710

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 8, 2024

@czs007 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added kind/feature Issues related to feature request from users and removed do-not-merge/missing-related-pr labels Jan 8, 2024
@SimFG
Copy link
Contributor

SimFG commented Jan 8, 2024

/lgtm

Copy link
Contributor

mergify bot commented Jan 8, 2024

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator Author

czs007 commented Jan 8, 2024

/run-cpu-e2e

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0c83440) 82.13% compared to head (22a8156) 82.12%.
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29762      +/-   ##
==========================================
- Coverage   82.13%   82.12%   -0.02%     
==========================================
  Files         832      832              
  Lines      119812   119823      +11     
==========================================
- Hits        98403    98400       -3     
- Misses      18192    18204      +12     
- Partials     3217     3219       +2     
Files Coverage Δ
internal/proxy/privilege_interceptor.go 74.01% <45.45%> (-2.71%) ⬇️

... and 14 files with indirect coverage changes

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 8, 2024
@sre-ci-robot sre-ci-robot merged commit 8c2ca3f into milvus-io:2.3 Jan 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants