Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revise the RESTful bulk insert API #29698

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Jan 4, 2024

Revise the RESTful bulk insert API from version 1 to version 2.

issue: #28521

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Jan 4, 2024
@bigsheeper bigsheeper mentioned this pull request Jan 4, 2024
12 tasks
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 4, 2024
@yellow-shine
Copy link
Collaborator

rerun ut

Copy link
Contributor

mergify bot commented Jan 12, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 31, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper bigsheeper changed the title feat: Suport RESTful bulkinsert api feat: Revise the RESTful bulk insert API Feb 2, 2024
Copy link
Contributor

mergify bot commented Feb 2, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 2, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.12%. Comparing base (52540fe) to head (9198497).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29698      +/-   ##
==========================================
- Coverage   81.15%   81.12%   -0.03%     
==========================================
  Files         972      972              
  Lines      139862   139862              
==========================================
- Hits       113507   113468      -39     
- Misses      22587    22625      +38     
- Partials     3768     3769       +1     
Files Coverage Δ
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <100.00%> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 89.58% <95.65%> (-0.13%) ⬇️

... and 15 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 23, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 23, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper bigsheeper force-pushed the 2312-import-restful branch from 87492de to b5d0836 Compare March 4, 2024 08:38
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Mar 4, 2024
Copy link
Contributor

mergify bot commented Mar 4, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 4, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify mergify bot added the ci-passed label Mar 4, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify mergify bot removed the ci-passed label Mar 5, 2024
@PowderLi
Copy link
Contributor

PowderLi commented Mar 5, 2024

/LGTM

@czs007
Copy link
Collaborator

czs007 commented Mar 5, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3b66c17 into milvus-io:master Mar 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants