Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inverted index file not found #29695

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

longjiquan
Copy link
Contributor

issue: #29654

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 4, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (99e0f1e) 83.72% compared to head (466b4e1) 83.78%.
Report is 38 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29695      +/-   ##
==========================================
+ Coverage   83.72%   83.78%   +0.05%     
==========================================
  Files         679      680       +1     
  Lines      108623   108751     +128     
==========================================
+ Hits        90949    91120     +171     
+ Misses      14361    14329      -32     
+ Partials     3313     3302      -11     
Files Coverage Δ
internal/datacoord/handler.go 79.85% <100.00%> (+0.29%) ⬆️
internal/datanode/syncmgr/storage_serializer.go 89.92% <100.00%> (+0.07%) ⬆️
internal/datanode/syncmgr/storage_v2_serializer.go 80.12% <100.00%> (+0.12%) ⬆️
internal/datanode/syncmgr/task.go 100.00% <100.00%> (+12.87%) ⬆️
internal/datanode/writebuffer/l0_write_buffer.go 70.37% <100.00%> (+2.37%) ⬆️
internal/datanode/writebuffer/write_buffer.go 92.07% <100.00%> (-1.33%) ⬇️
internal/proxy/meta_cache.go 89.64% <100.00%> (-0.18%) ⬇️
internal/proxy/task.go 85.48% <100.00%> (ø)
internal/proxy/task_delete.go 85.98% <100.00%> (ø)
internal/proxy/task_index.go 75.74% <100.00%> (ø)
... and 27 more

... and 10 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 5, 2024
@czs007
Copy link
Collaborator

czs007 commented Jan 5, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Jan 5, 2024

/lgtm

Copy link
Contributor

mergify bot commented Jan 5, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 5, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@yellow-shine
Copy link
Collaborator

rerun ut

@czs007
Copy link
Collaborator

czs007 commented Jan 7, 2024

/lgtm

@mergify mergify bot added the ci-passed label Jan 7, 2024
@sre-ci-robot sre-ci-robot merged commit e9f3df3 into milvus-io:master Jan 7, 2024
17 checks passed
@longjiquan longjiquan deleted the use-boost-iter branch January 8, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants