fix: Unexpected rpc msg size limit #29682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29682 +/- ##
==========================================
- Coverage 83.72% 80.91% -2.82%
==========================================
Files 679 922 +243
Lines 108623 127409 +18786
==========================================
+ Hits 90949 103087 +12138
- Misses 14361 21028 +6667
+ Partials 3313 3294 -19
|
weiliu1031
force-pushed
the
fix_rpc_size_limit
branch
from
99c462a to
85939bc
Compare
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031
force-pushed
the
fix_rpc_size_limit
branch
from
85939bc to
b2e9d87
Compare
|
@weiliu1031 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
1 similar comment
|
/run-cpu-e2e |
|
rerun ut |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Jan 15, 2024
due to `clientMaxSendSize` and `serverMaxRecvSize` will limit the rpc request size limit, they should use same config value, and `serverMaxSendSize` and `clientMaxRecvSize` will limit the rpc response size limit, they should use same config value too. This PR fix unexpected rpc msg limit which caused by the wrong usage of misunderstanding rpc config items Signed-off-by: Wei Liu <wei.liu@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 16, 2024
pr: #29682 due to `clientMaxSendSize` and `serverMaxRecvSize` will limit the rpc request size limit, they should use same config value, and `serverMaxSendSize` and `clientMaxRecvSize` will limit the rpc response size limit, they should use same config value too. This PR fix unexpected rpc msg limit which caused by the wrong usage of misunderstanding rpc config items Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to
clientMaxSendSizeandserverMaxRecvSizewill limit the rpc request size limit, they should use same config value, andserverMaxSendSizeandclientMaxRecvSizewill limit the rpc response size limit, they should use same config value too.This PR fix unexpected rpc msg limit which caused by the wrong usage of misunderstanding rpc config items