Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: use GPU pool for gpu tasks #29678

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Jan 4, 2024

  • this much improve the performance for GPU index

- this much improve the performance for GPU index

Signed-off-by: yah01 <yang.cen@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (99e0f1e) 83.72% compared to head (752184e) 80.83%.
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29678      +/-   ##
==========================================
- Coverage   83.72%   80.83%   -2.89%     
==========================================
  Files         679      922     +243     
  Lines      108623   127316   +18693     
==========================================
+ Hits        90949   102922   +11973     
- Misses      14361    21081    +6720     
  Partials     3313     3313              
Files Coverage Δ
internal/querynodev2/tasks/query_stream_task.go 80.95% <100.00%> (+0.95%) ⬆️
internal/querynodev2/tasks/query_task.go 89.88% <100.00%> (+0.23%) ⬆️
internal/querynodev2/tasks/task.go 77.25% <100.00%> (+0.19%) ⬆️
internal/querynodev2/tasks/tasks.go 57.89% <ø> (ø)
pkg/util/indexparamcheck/index_type.go 100.00% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.13% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/segments/collection.go 90.84% <81.81%> (-0.76%) ⬇️
...nal/querynodev2/tasks/concurrent_safe_scheduler.go 88.42% <57.14%> (-1.26%) ⬇️

... and 264 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 4, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9e0163e into milvus-io:master Jan 4, 2024
14 checks passed
yah01 added a commit to yah01/milvus that referenced this pull request Jan 8, 2024
- this much improve the performance for GPU index

Signed-off-by: yah01 <yang.cen@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jan 9, 2024
- this much improve the performance for GPU index
- this also reduce 1x copy while parsing index meta
pr: #29678

Signed-off-by: yah01 <yang.cen@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants