enhance: cache collection schema attributes to reduce proxy cpu #29668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia ut workflow job failed, comment |
See also milvus-io#29113 The collection schema is crucial when performing search/query but some of the information is calculated for every request. This PR change schema field of cached collection info into a utility `schemaInfo` type to store some stable result, say pk field, partitionKeyEnabled, etc. And provided field name to id map for search/query services. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
force-pushed
the
refine_proxy_metacache_schema
branch
from
1584e98 to
19037a9
Compare
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@congqixia E2e jenkins job failed, comment |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29668 +/- ##
==========================================
- Coverage 83.72% 80.85% -2.88%
==========================================
Files 679 921 +242
Lines 108623 127304 +18681
==========================================
+ Hits 90949 102926 +11977
- Misses 14361 21071 +6710
+ Partials 3313 3307 -6
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jan 4, 2024
…us-io#29668) See also milvus-io#29113 The collection schema is crucial when performing search/query but some of the information is calculated for every request. This PR change schema field of cached collection info into a utility `schemaInfo` type to store some stable result, say pk field, partitionKeyEnabled, etc. And provided field name to id map for search/query services. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
any performance comparison? |
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 7, 2024
…roxy cpu (#29668) (#29692) Cherry-pick from master pr: #29668 See also #29113 The collection schema is crucial when performing search/query but some of the information is calculated for every request. This PR change schema field of cached collection info into a utility `schemaInfo` type to store some stable result, say pk field, partitionKeyEnabled, etc. And provided field name to id map for search/query services. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #29113
The collection schema is crucial when performing search/query but some of the information is calculated for every request.
This PR change schema field of cached collection info into a utility
schemaInfotype to store some stable result, say pk field, partitionKeyEnabled, etc. And provided field name to id map for search/query services.