Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the entity num metric accurate #29643

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Jan 3, 2024

fix #29642

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 3, 2024
Copy link
Contributor

mergify bot commented Jan 3, 2024

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jan 4, 2024

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01 yah01 force-pushed the fix-entity-num-metric branch 2 times, most recently from 595b712 to cf5673e Compare January 4, 2024 08:21
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 4, 2024
sre-ci-robot pushed a commit that referenced this pull request Jan 4, 2024
fix #29642
pr: #29643

Signed-off-by: yah01 <yang.cen@zilliz.com>
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (3561586) 80.82% compared to head (889121d) 83.68%.
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29643      +/-   ##
==========================================
+ Coverage   80.82%   83.68%   +2.86%     
==========================================
  Files         926      686     -240     
  Lines      127767   109175   -18592     
==========================================
- Hits       103271    91367   -11904     
+ Misses      21145    14456    -6689     
- Partials     3351     3352       +1     
Files Coverage Δ
internal/allocator/cached_allocator.go 73.04% <100.00%> (ø)
internal/datacoord/channel_manager.go 77.61% <100.00%> (ø)
internal/datacoord/compaction_trigger.go 85.08% <100.00%> (ø)
internal/datacoord/segment_manager.go 88.04% <100.00%> (+0.50%) ⬆️
internal/datanode/event_manager.go 76.34% <100.00%> (ø)
internal/indexnode/indexnode.go 82.12% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/client/client_impl.go 82.90% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/client/consumer_impl.go 96.29% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 83.77% <100.00%> (+0.36%) ⬆️
...rnal/mq/mqimpl/rocksmq/server/rocksmq_retention.go 76.72% <100.00%> (ø)
... and 46 more

... and 254 files with indirect coverage changes

@yah01 yah01 force-pushed the fix-entity-num-metric branch from cf5673e to 1f80e27 Compare January 5, 2024 03:29
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 5, 2024
Copy link
Contributor

mergify bot commented Jan 5, 2024

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Jan 5, 2024

rerun ut

Signed-off-by: yah01 <yang.cen@zilliz.com>
@yah01 yah01 force-pushed the fix-entity-num-metric branch from 1f80e27 to 889121d Compare January 5, 2024 08:20
@mergify mergify bot added the ci-passed label Jan 5, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a0cec40 into milvus-io:master Jan 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: entity_num metric not accurate
3 participants