Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw exception when upload file failed for DiskIndex #29627

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Jan 2, 2024

related to : #29417

cardinal indexes upload index files in Serialize interface, and throw exception when the Serialize failed.

Signed-off-by: xianliang <xianliang.li@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: foxspy
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 2, 2024
Copy link
Contributor

mergify bot commented Jan 2, 2024

@foxspy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@foxspy foxspy changed the title fix : throw exception when upload file failed for DiskIndex fix: throw exception when upload file failed for DiskIndex Jan 2, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Jan 2, 2024
sre-ci-robot pushed a commit that referenced this pull request Jan 3, 2024
…dex (#29628)

Cherry pick from master
pr: #29627 
related to: #29417

Signed-off-by: xianliang <xianliang.li@zilliz.com>
@foxspy
Copy link
Contributor Author

foxspy commented Jan 3, 2024

rerun ut

1 similar comment
@foxspy
Copy link
Contributor Author

foxspy commented Jan 4, 2024

rerun ut

@czs007 czs007 merged commit 271edc6 into milvus-io:master Jan 7, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants