Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Read azure file without ReadAll #29602

Merged
merged 1 commit into from
Jan 4, 2024
Merged

enhance: Read azure file without ReadAll #29602

merged 1 commit into from
Jan 4, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #29292

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 29, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 29, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 29, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333 xiaocai2333 mentioned this pull request Dec 29, 2023
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 29, 2023

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2023

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 2, 2024
@xiaocai2333
Copy link
Contributor Author

rerun ut

1 similar comment
@xiaocai2333
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun ut

2 similar comments
@xiaocai2333
Copy link
Contributor Author

rerun ut

@xiaocai2333
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@xiaocai2333
enhance: Read azure file without ReadAll
db6c9c7 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99e0f1e) 83.72% compared to head (db6c9c7) 71.50%.
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #29602       +/-   ##
===========================================
- Coverage   83.72%   71.50%   -12.23%     
===========================================
  Files         679      920      +241     
  Lines      108623   127278    +18655     
===========================================
+ Hits        90949    91008       +59     
- Misses      14361    32969    +18608     
+ Partials     3313     3301       -12
Files Coverage Δ
internal/storage/azure_object_storage.go 92.30% <94.64%> (+1.13%) ⬆️

... and 264 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jan 4, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit dc8b5c1 into milvus-io:master Jan 4, 2024
13 of 14 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jan 4, 2024
@xiaocai2333
enhance: Read azure file without ReadAll (#29604)
2d64cd7 
issue: #29292 
master pr: #29602

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 deleted the fix_azure_import branch January 5, 2024 06:19
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@PowderLi PowderLi Awaiting requested review from PowderLi

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@czs007 czs007

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaocai2333 @xiaofan-luan @sre-ci-robot @czs007