feat: Add import scheduler and manager #29367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…2-binlog-reader
…2-binlog-reader
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…2-binlog-reader
…2-binlog-reader
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…2-binlog-reader
…2-binlog-reader
…2-binlog-reader
…2-binlog-reader
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…2-binlog-reader
…2-binlog-reader
…2-binlog-reader
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…2-binlog-reader
czs007
reviewed
Feb 22, 2024
czs007
reviewed
Feb 22, 2024
czs007
reviewed
Feb 22, 2024
czs007
reviewed
Feb 22, 2024
czs007
reviewed
Feb 22, 2024
czs007
reviewed
Feb 23, 2024
czs007
reviewed
Feb 23, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…2-import-scheduler
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
|
rerun ut |
czs007
reviewed
Mar 1, 2024
internal/datacoord/import_util.go
Outdated
| }) | ||
| segmentIDs := task.(*importTask).GetSegmentIDs() | ||
| for _, segmentID := range segmentIDs { | ||
| segment := meta.GetSegment(segmentID) |
czs007
reviewed
Mar 1, 2024
internal/datacoord/import_util.go
Outdated
| } | ||
| return int64(progress), internalpb.ImportState_InProgress, "" | ||
| return 0, internalpb.ImportJobState_Failed, "unknown import job state" |
czs007
reviewed
Mar 1, 2024
internal/datacoord/import_checker.go
Outdated
| @@ -276,72 +270,61 @@ func (c *importChecker) checkImportState(job ImportJob) { | |||
| return | |||
| } | |||
| c.buildIndexCh <- segmentID // accelerate index building | |||
| err = c.meta.UnsetIsImporting(segmentID) | |||
| segment := c.meta.GetSegment(segmentID) | |||
There was a problem hiding this comment.
minimize the number of calsl of meta.GetSegment
czs007
reviewed
Mar 1, 2024
internal/datacoord/import_checker.go
Outdated
| } | ||
| } | ||
|
|
||
| func (c *importChecker) checkTimeout(jobID int64) { | ||
| tasks := c.imeta.GetTaskBy(WithStates(internalpb.ImportState_InProgress), WithJob(jobID)) | ||
| func (c *importChecker) checkFailedJob(job ImportJob) { |
There was a problem hiding this comment.
rename to tryFailingTasks
czs007
reviewed
Mar 1, 2024
internal/datacoord/import_checker.go
Outdated
|
|
||
| timeoutTime := tsoutil.PhysicalTime(c.imeta.GetJob(jobID).GetTimeoutTs()) | ||
| func (c *importChecker) checkTimeout(job ImportJob) { |
czs007
reviewed
Mar 1, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…2-import-scheduler
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MrPresent-Han
pushed a commit
to MrPresent-Han/milvus
that referenced
this pull request
Mar 3, 2024
This PR introduces novel managerial roles for importv2: 1. ImportMeta: To manage all the import tasks; 2. ImportScheduler: To process tasks and modify their states; 3. ImportChecker: To ascertain the completion of all tasks and instigate relevant operations. issue: milvus-io#28521 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces novel managerial roles for importv2:
issue: #28521