Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add import reader for numpy #29253

Merged
merged 20 commits into from
Jan 8, 2024
Merged

feat: Add import reader for numpy #29253

merged 20 commits into from
Jan 8, 2024

Conversation

bigsheeper
Copy link
Contributor

This PR implements a new numpy reader for import.

issue: #28521

@bigsheeper
feat: Add import reader for numpy
539c837 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 16, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Dec 16, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2023

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 18, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

Attention: 636 lines in your changes are missing coverage. Please review.

Comparison is base (3561586) 80.82% compared to head (bd4d242) 83.33%.
Report is 28 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29253      +/-   ##
==========================================
+ Coverage   80.82%   83.33%   +2.50%     
==========================================
  Files         926      691     -235     
  Lines      127767   110087   -17680     
==========================================
- Hits       103271    91743   -11528     
+ Misses      21145    14896    -6249     
- Partials     3351     3448      +97
Files Coverage Δ
internal/allocator/cached_allocator.go 73.04% <100.00%> (ø)
internal/datacoord/channel_manager.go 77.14% <100.00%> (-0.48%) ⬇️
internal/datacoord/compaction_trigger.go 85.08% <100.00%> (ø)
internal/datacoord/segment_manager.go 88.80% <100.00%> (+1.27%) ⬆️
internal/datanode/event_manager.go 76.34% <100.00%> (ø)
internal/indexnode/indexnode.go 82.12% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/client/client_impl.go 82.90% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/client/consumer_impl.go 96.29% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 83.41% <100.00%> (ø)
...rnal/mq/mqimpl/rocksmq/server/rocksmq_retention.go 76.72% <100.00%> (ø)
... and 54 more

... and 250 files with indirect coverage changes

@bigsheeper
code format
84eec47 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper
Merge branch 'master' of https://github.com/milvus-io/milvus into 231…
de37615 
…2-numpy-reader
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@bigsheeper bigsheeper mentioned this pull request Dec 20, 2023
Closed
12 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun ut

@bigsheeper
fix conflicts
f9c9614 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper
fix
5ed38e2 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@bigsheeper
code format
1504dca 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@xiaocai2333
Copy link
Contributor

/lgtm
add more unit tests.

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun ut

@yellow-shine
Copy link
Collaborator

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 5, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 5, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Jan 5, 2024
@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@bigsheeper
Merge branch 'master' of https://github.com/milvus-io/milvus into 231…
33e3691 
…2-numpy-reader
@bigsheeper
read by count
bd4d242 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Jan 5, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bigsheeper
Copy link
Contributor Author

rerun ut

3 similar comments
@bigsheeper
Copy link
Contributor Author

rerun ut

@bigsheeper
Copy link
Contributor Author

rerun ut

@bigsheeper
Copy link
Contributor Author

rerun ut

@czs007
Copy link
Collaborator

czs007 commented Jan 8, 2024

/lgtm

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 8, 2024
@sre-ci-robot sre-ci-robot merged commit 3d07b66 into milvus-io:master Jan 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@xiaocai2333 xiaocai2333

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm manual-pass manually set pass before ci-passed labeled size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bigsheeper @xiaocai2333 @yellow-shine @czs007 @sre-ci-robot