Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add import reader for json #29252

Merged
merged 11 commits into from
Jan 5, 2024

Conversation

bigsheeper
Copy link
Contributor

This PR implements a new json reader for import.

issue: #28521

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 16, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Dec 16, 2023
Copy link
Contributor

mergify bot commented Dec 16, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 16, 2023

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 331 lines in your changes are missing coverage. Please review.

Comparison is base (99e0f1e) 83.72% compared to head (2a666c1) 83.52%.
Report is 26 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29252      +/-   ##
==========================================
- Coverage   83.72%   83.52%   -0.21%     
==========================================
  Files         679      681       +2     
  Lines      108623   109098     +475     
==========================================
+ Hits        90949    91124     +175     
- Misses      14361    14613     +252     
- Partials     3313     3361      +48     
Files Coverage Δ
pkg/util/typeutil/schema.go 80.82% <50.00%> (-0.23%) ⬇️
internal/storage/insert_data.go 96.42% <45.45%> (-0.93%) ⬇️
internal/util/importutilv2/json/reader.go 33.73% <33.73%> (ø)
internal/util/importutilv2/json/row_parser.go 29.73% <29.73%> (ø)

... and 16 files with indirect coverage changes

@bigsheeper bigsheeper mentioned this pull request Dec 16, 2023
12 tasks
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Dec 19, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 19, 2023

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor

/lgtm
add more unit test

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 2, 2024
Copy link
Contributor

mergify bot commented Jan 2, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Jan 2, 2024

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

pkg/util/typeutil/schema.go Outdated Show resolved Hide resolved
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Jan 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 23183ff into milvus-io:master Jan 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants