Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of concurrent gRPC requests (#27718) #27719

Closed
wants to merge 1 commit into from

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Oct 16, 2023

/kind improvement
pr: #27718

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor area/compilation area/dependency Pull requests that update a dependency file area/internal-api area/test sig/testing size/XXL Denotes a PR that changes 1000+ lines. labels Oct 16, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yah01
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Oct 16, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #27719 (1b20c6a) into 2.2.0 (6fee34f) will increase coverage by 0.01%.
Report is 3 commits behind head on 2.2.0.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #27719      +/-   ##
==========================================
+ Coverage   80.93%   80.94%   +0.01%     
==========================================
  Files         745      745              
  Lines      109239   109269      +30     
==========================================
+ Hits        88408    88451      +43     
+ Misses      17474    17465       -9     
+ Partials     3357     3353       -4     
Files Coverage Δ
internal/distributed/datacoord/service.go 86.41% <100.00%> (+0.05%) ⬆️
internal/distributed/datanode/service.go 76.54% <100.00%> (+0.09%) ⬆️
internal/distributed/indexnode/service.go 68.96% <100.00%> (+0.17%) ⬆️
internal/distributed/proxy/service.go 75.23% <100.00%> (+0.06%) ⬆️
internal/distributed/querycoord/service.go 71.82% <100.00%> (+0.11%) ⬆️
internal/distributed/querynode/service.go 81.59% <100.00%> (+0.09%) ⬆️
internal/distributed/rootcoord/service.go 80.00% <100.00%> (+0.07%) ⬆️
internal/util/paramtable/grpc_param.go 78.72% <75.00%> (-0.17%) ⬇️

... and 21 files with indirect coverage changes

Signed-off-by: yah01 <yah2er0ne@outlook.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parameter this pr set is MaxConcurrentStreams, which is not equivalent to concurrent requests

@yah01
Copy link
Member Author

yah01 commented Oct 16, 2023

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. do-not-merge/hold kind/improvement Changes related to something improve, likes ut and code refactor sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants