Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexNode panic if storage config empty #26302

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Aug 11, 2023

/kind bug
fix #26301

Signed-off-by: yah01 <yah2er0ne@outlook.com>
@sre-ci-robot sre-ci-robot added kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines. labels Aug 11, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #26302 (197569e) into master (9489e14) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #26302    +/-   ##
========================================
  Coverage   82.61%   82.62%            
========================================
  Files         812      812            
  Lines      109158   109528   +370     
========================================
+ Hits        90182    90498   +316     
- Misses      15841    15891    +50     
- Partials     3135     3139     +4     
Files Changed Coverage Δ
internal/indexnode/chunk_mgr_factory.go 84.21% <100.00%> (ø)

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 11, 2023
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8391059 into milvus-io:master Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: IndexNode panic while create job if the storage config is nil
4 participants