Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix load index with empty file list #26236

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix load index with empty file list #26236

merged 1 commit into from
Aug 9, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Aug 9, 2023

/kind bug
related #26178 #25780 #26131 #25905

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Aug 9, 2023
@sre-ci-robot sre-ci-robot requested review from congqixia and sunby August 9, 2023 07:12
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 9, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01 yah01 force-pushed the fix-index-file-empty branch from 5b2b34f to 8599a92 Compare August 9, 2023 08:08
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #26236 (ecd312a) into master (fb5d809) will increase coverage by 0.34%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26236      +/-   ##
==========================================
+ Coverage   82.22%   82.57%   +0.34%     
==========================================
  Files         817      811       -6     
  Lines      111187   108768    -2419     
==========================================
- Hits        91427    89816    -1611     
+ Misses      16652    15821     -831     
- Partials     3108     3131      +23
Files Changed Coverage Δ
internal/querycoordv2/checkers/index_checker.go 81.72% <100.00%> (+0.40%) ⬆️
internal/querynodev2/segments/segment_loader.go 73.07% <100.00%> (+0.15%) ⬆️

... and 183 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01 yah01 force-pushed the fix-index-file-empty branch from 8599a92 to dbb0317 Compare August 9, 2023 09:15
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Aug 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01
Fix load index with empty file list
ecd312a 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
@yah01 yah01 force-pushed the fix-index-file-empty branch from dbb0317 to ecd312a Compare August 9, 2023 09:36
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia
congqixia approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Aug 9, 2023
@sre-ci-robot sre-ci-robot merged commit 889424b into milvus-io:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @sre-ci-robot @congqixia