Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated grpc WithInsecure option #26226

Merged

Conversation

congqixia
Copy link
Contributor

/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 9, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Aug 9, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 9, 2023
@jiaoew1991
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #26226 (c26e457) into master (21eeb37) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26226      +/-   ##
==========================================
- Coverage   82.58%   82.57%   -0.01%     
==========================================
  Files         811      811              
  Lines      108725   108753      +28     
==========================================
+ Hits        89790    89807      +17     
- Misses      15805    15818      +13     
+ Partials     3130     3128       -2     
Files Changed Coverage Δ
internal/distributed/connection_manager.go 70.41% <100.00%> (+0.33%) ⬆️
internal/util/grpcclient/client.go 79.60% <100.00%> (-0.96%) ⬇️

... and 21 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 9, 2023
@sre-ci-robot sre-ci-robot merged commit e13b6b8 into milvus-io:master Aug 9, 2023
@congqixia congqixia deleted the remove_deprecated_withinsecure branch August 14, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants