Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unexpected score in look aside balancer #26213

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Aug 8, 2023

Signed-off-by: Wei Liu wei.liu@zilliz.com
issue #25452

to avoid unexpected negative executingNq/totalNq, which causes the balancer uses a max float64 value as score, caused a unbalanced request assignment

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Aug 8, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #26213 (c3baaf6) into master (b6effd7) will decrease coverage by 0.02%.
Report is 32 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26213      +/-   ##
==========================================
- Coverage   82.58%   82.57%   -0.02%     
==========================================
  Files         811      811              
  Lines      108695   108712      +17     
==========================================
  Hits        89770    89770              
- Misses      15798    15813      +15     
- Partials     3127     3129       +2     
Files Changed Coverage Δ
internal/proxy/look_aside_balancer.go 96.91% <100.00%> (+0.20%) ⬆️
pkg/metrics/proxy_metrics.go 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 8, 2023
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Aug 10, 2023
@sre-ci-robot sre-ci-robot merged commit 05c87af into milvus-io:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants